Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make initial value of signal() optional in types #116

Closed
wants to merge 4 commits into from
Closed

Make initial value of signal() optional in types #116

wants to merge 4 commits into from

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Sep 10, 2022

Better matching the type of useState() in preact/hooks.

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 683d9e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Sep 10, 2022 •
edited
Loading

✅ Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 683d9e3
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/64142cfc7461aa00082a4c00
😎 Deploy Preview https://deploy-preview-116--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kidonng
Copy link
Contributor Author

kidonng commented Mar 17, 2023

@marvinhagemeister Hi, could you please take a look?

@kidonng
Copy link
Contributor Author

kidonng commented Jul 8, 2024

Resolved in #578 🎉

@kidonng kidonng closed this Jul 8, 2024
@kidonng kidonng mentioned this pull request Jul 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kidonng